Florida Cranberry, Roselle Hibiscus sabdariffa

What zone are you in?

Here is a link that might be useful: Roselle

Flowering cabbage and kale. Not a true flower, but just as pretty as one.

Chives and garlic chives. Bloom season is kind of short, but both are pretty and completely edible.

You already mentioned violets. Pansies and violas are, too.

Amaranth is very attractive and totally edible. There are both ornamental and vegetable types.

The Japanese potherb Shungiku, edible chrysanthemum, has edible leaves and bright yellow daisy type flowers. Perilla, or Japanese Basil, has very attractive burgundy leaves, and the entire plant is very similar to coleus and can be used the same way.

Many herbs aren't really grown for flowers, but have very ornamental foliage -- think variegated varieties of things like basil, sage, mints. Scented leaved geraniums have small but often kind of attractive flowers, and the leaves can be used in herbal teas and to flavor jams and jellies.

A lot of the ornamental sweet potato vines have very attractive variegated foliage, too, that is edible (very commonly used as a cooked green in many Asian cuisines, especially in the Phillipines).

Sorry, forgot to enter the zone. (western NC) I thought there was no answer so stopped checking after a few days. Thanks very much for the additions to my list.

Chocolate flower, it has a bloom from may to october. Do I need to say what it smells like??

day lilies are edible and delicious--shoots goodi n salad, flowers fresh and dried are edible, roots are edible. Any mints--for example, beebalm. Sunflowers.

Any of the alliums ... herbs like chicory, basil, borage, thyme, rosemary, lavender ... and strawberries!

There is a great book by Fred Hagy called Landscaping with Fruits and Vegetables which lists several dozen edible flowers. I recall nastursium, primrose, daylily, hollyhock and tulip being among them. Many vegetables are ornamental as well: kale, cauliflower, eggplants, red okra and peppers - but watch out for the hot ones!