Maybe oleander, but it's too far away to know for sure.

Ditto exactly what Dave said.

The curving edging and uneven planting in front are inconsistent with the formal planting behind. The hedge looks like they are having to shear it rather often to maintain the effect, also the leaves are too big for this use - as they would be on an oleander. Oleander is also quite poisonous, depending on your situation you may not want to duplicate the planting shown for that reason alone.

Im wanting something that grows upright with long branches like these. Any suggestions?

Probably a dwarf variety of oleander would do the job. Something like 'Petite Pink'.

Consult your local good garden center and see what they recommend for your area. Mention DWARF to them. Or tell them exactly how high you want your hedge to be and they may have some better suggestions.