No garage? You park in the front of the house and come in that way?

How old are your children?

Is this a forever home?

My nephews share a room. They recently remodeled and made a small walk-in closet for each. They are pretty much bare minimum for walk-ins but it provides each child their own space. That has been really nice for them (and funny to see their personalities - one is very tidy and the other is not.)

In the kids bathroom, I would also recommend putting the toilet and shower in a separate room from the sink so one child can be in there and the others can be brushing teeth, etc. And try to find room for at least a little counterspace in the kids bathroom. At least enough space so they can each have a drawer.

Master bathroom - put the vanity across from the door. Shower where the toilet is, flipped the other way. And toilet at the end of the shower.

Add measurements to the upstairs floorplan and hope a pro will weight in and help with the layout.

Edited to add that we will be taking these plans to an architect

You take ideas/wants/desires to your architect. It's their job to create the plan.

@K8cd

Yes we have a garage. It is beside the kitchen windows and the driveway runs down to the front. We will have a wrap around porch along the front, side and back. We don't park in the garage, we park in front of the garage beside where the front entrance is. Our children are 11, 10, 8 and 1. Yes it's our forever home hopefully. Yes the kids bathroom will have a small vanity with sink, I should have added that

What was the layout before?

Agree with PPF. Where did these plans come from? Something you created on some digital platform? You would be far better off giving your wish list and parameters to a licensed local architect, let him/her walk the site and inspect the existing house, then let them create a design which meets your needs and your budget.

Assuming your 'very old home' has a very old foundation, have a builder and/or engineer inspect the foundation and talk about the ramifications of removing a very old home off of a very old foundation and building a new home on top of a very old foundation. There may be zoning issues, construction integrity issues, logistics issues, and maybe functional space issues.

PPF. and RappArchitecture are right.

The age dif between the 1-year-old and sibling is not going to work. Because you're casual, a litchen table instead of an island can work for your family. The dining room is wasted space. Better to have a larger spacious kitchen with pretty of kitchen table and chairs space.

As a doctor posted this sign at office entry:

"If you have Googled your condition, and diagnosed yourself? Turn around now"

................

Take your dreams to the architect, please. Leave your plan on your computer, or better? Delete it.

Any design starts with the site. Design does not stop at the exterior walls, it stops at the property lines but of course will be influenced by factors beyond the property lines. You need to show us the house as it sits on the site.

And any architecture is three dimensional. We need to see elevations and a 3D model.

You mention having a lovely river view out the south side. You are taking advantage of it upstairs, but ignoring it downstairs. I think that is a missed opportunity.