I agree that brass is pretty out of style. There are so many different hardware options now. Consider changing to chrome, brushed nickel, oil rubbed bronze, crystal, etc. There is really no right or wrong. You should choose according to the style of your house. If your house is a certain style then the type of hardware will always be in style because it will always match your house.

You might want to hold off on this - we are starting to see gold and brass tones coming back! (Just in time to change everything to chrome)

I think brass goes well with certain eclectic or rustic styles. Depending on the overall theme it could definitely be an advantage.