Impossible to tell from your description. Do you have a wiring diagram for before and after?

I don't have a before but I'll try to explain it better

Thanks for the reply, so this junction box had 2 other wires coming in 1 was for the lightswitch and the other was for another lights that I got rid of, the weird part was that the light switch wire used the white as the "hot" wire, I moved that wire else where to install pot light

I wired it with like colors but when the breaker is on and light switch is on, the breaker trips. When light switch is off the pot light light stays on and doesn't trip until you flick the lightswitch.

The first junction box picture goes to my furnace switch don't know if that matters

One problem is that when wiring is done with cables that have only black and white wires, the white ones are sometimes used to carry power. In your situation, I would first get a contact tester (the non-contact ones frequently give false positives). Then, with the power off, remove all the wire nuts and make sure the wires themselves aren't touching anything. Then turn on the power and check each wire for power, relative to ground. Repeat this with your switch(es) in each position. Any time a white wire shows power, mark it with red tape (or, perhaps another color other than black or green). This should give you enough information to figure out the problem.

If your hot wire came in from your light then went from there to your switch that would explain how your White wire would be used as the hot wire. Its normal in this situation but I like to mark with black tape. It is important for you to find out which wire has the voltage coming in so you can hook up the switch properly, it sounds like you bypassed the switch although that shouldn't have jumped the breaker.

Also be sure to use proper cable clamps where the cables enter the boxes. It looks like none are present in that second photo.